This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] gcc/reload.c: Initialize several arrays before use them in find_reloads()
- From: Jeff Law <law at redhat dot com>
- To: Chen Gang S <gang dot chen at sunrus dot com dot cn>, "augustine dot sterling at gmail dot com" <augustine dot sterling at gmail dot com>
- Cc: Steven Bosscher <stevenb dot gcc at gmail dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>, Richard Henderson <rth at redhat dot com>, gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 24 Feb 2015 12:22:36 -0700
- Subject: Re: [PATCH] gcc/reload.c: Initialize several arrays before use them in find_reloads()
- Authentication-results: sourceware.org; auth=none
- References: <54E99B0E dot 2080109 at sunrus dot com dot cn> <54EBA926 dot 30207 at redhat dot com> <CABu31nPrpNmLQapXcu_XF0S12DKM27eVrTJ9GER=eN6oo=L7VA at mail dot gmail dot com> <54EBB454 dot 9000601 at redhat dot com> <54EBD4ED dot 4080605 at sunrus dot com dot cn> <54EC9ECE dot 8030709 at redhat dot com> <54ECAF71 dot 6010202 at sunrus dot com dot cn> <CAGSvup8Q6cYsRV4KYn0HEwpOO9daWkyUBCX7TVRheFA1Oq8m9A at mail dot gmail dot com> <54ECB50F dot 8000207 at sunrus dot com dot cn>
On 02/24/15 10:29, Chen Gang S wrote:
Yes, I think an error would be appropriate here. That way nobody has to
debug same issue you just did in find_reloads.
On 2/25/15 01:03, email@example.com wrote:
On Tue, Feb 24, 2015 at 9:05 AM, Chen Gang S <firstname.lastname@example.org> wrote:
- After this patch, it can continue compiling, but can we be sure that
it always generates correct code for execution?
After this patch, it should be no worse than it was--lucky.
Someone is working on fixing the underlying xtensa pattern in the
short term. So I would continue whether or not the generated code is
Another short-term option would be to use an xtensa config that
doesn't have zero-over-head loops.
OK, thank you for your response.
So for me, I shall let genrecog report error instead of warning when it
find this issue, next.