This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix up pr44194-1.c testcase (PR testsuite/64158)


On 02/20/15 07:43, Jakub Jelinek wrote:
Hi!

As written in the PR, this testcase is supposed to be blacklisted on
(lp64) powerpc*-*-linux* unless powerpc_elfv2 and also on nvptx,
but apparently neither of those blacklistings really work.
tcl or dejagnu or the target expression parser are unhappy about the
missing {}s, it doesn't like cond1 && cond2 && cond3 but wants
{ { cond1 && cond2 } && cond3 } instead (fixes the powerpc* blacklisting)
and was missing another pair of {}s around the whole thing (that should fix
nvptx).

Regtested on x86_64-linux and i686-linux, additionally tested with
replacing the various targets in the expression with x86_64-*-* instead
and checking the test became UNSUPPORTED as it should.  Ok for trunk?

2015-02-20  Jakub Jelinek  <jakub@redhat.com>

	PR testsuite/64158
	* gcc.dg/pr44194-1.c: Add two extra {} pairs to fix up powerpc*-*-linux*
	and nvptx-*-* blacklisting.
Got to love the unholy trinity of dejagnu, expect & tcl...


OK.
jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]