This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix testsuite race on additional_sources


On 02/18/15 08:05, Maxim Kuvyrkov wrote:
Hi,

This testsuite patch fixes race on additional_source testsuite variable.  When a test has both dg-additional-sources and "dg-do run { target FOO }" directives, it may occur that the FOO test will attempt to use additional_sources, which will result in failure to compile FOO test.  It often happens that FOO test was done for one of the previous testcases (which didn't use dg-additional-sources), so the failure case is not stable.

This behavior can be more-or-less reliably triggered with

make check-gcc make RUNTESTFLAGS="i386.exp=gcc.target/i386/pr64291-1.c"

The attached patch fixes the problem.  OK for trunk and 4.9 branch?
Yes, this is fine.
Jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]