This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] Fix android build.
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Ilya Tocar <tocarip dot intel at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 18 Feb 2015 12:08:31 +0100
- Subject: Re: [Patch] Fix android build.
- Authentication-results: sourceware.org; auth=none
- References: <20150218105925 dot GA9876 at msticlxl7 dot ims dot intel dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Feb 18, 2015 at 01:59:25PM +0300, Ilya Tocar wrote:
> Hi,
>
> On android dlerror returns const char*.
Looks like POSIX violation.
> Ok for trunk?
>
> libgomp/
> * target.c (gomp_load_plugin_for_device): Fix type of dlerror
> return value.
> (DLSYM_OPT): Ditto.
Therefore, I wouldn't word the ChangeLog entry this way, because it
isn't fixing it, it is working around Android bug.
So what about
Use const char * instead of char * for variables holding dlerror return
values.
? Ok with that change.
Jakub