This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Use !implicit_section in the recent set_section change (PR ipa/65087)
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Jan Hubicka <hubicka at ucw dot cz>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 17 Feb 2015 22:00:40 +0100
- Subject: Re: [PATCH] Use !implicit_section in the recent set_section change (PR ipa/65087)
- Authentication-results: sourceware.org; auth=none
- References: <20150217204743 dot GB1746 at tucnak dot redhat dot com>
> Hi!
>
> Markus reported an ICE, that is fixed by following patch, which limits
> the earlier change to !implicit_section only (which I assume is the user
> supplied __attribute__((section ()))).
>
> Bootstrapped/regtested on {x86_64,i686,aarch64,ppc64,ppc64le,s390,s390x}-linux.
> Ok for trunk?
>
> 2015-02-17 Jakub Jelinek <jakub@redhat.com>
>
> PR ipa/65087
> * cgraphclones.c (cgraph_node::create_virtual_clone): Only copy
> section if !implicit_section.
> (cgraph_node::create_version_clone_with_body): Likewise.
> * trans-mem.c (ipa_tm_create_version): Likewise.
This seems OK. I wonder what the bug Markus reported is.
Can you, please, double check that with -ffunction-sections the clones will be
eventually run across resolve_unique_section and not say in the anonymous one?
Honza