This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, avr] Fix ICE PR64452 pushing eliminated rtxes


2015-02-17 14:12 GMT+03:00 Georg-Johann Lay <avr@gjlay.de>:
> Byte-wise pushing virtual regs like arg pointer migth result in patterns
> like
>
>  (set (mem:QI (post_dec:HI (reg:HI 32 SP)))
>       (subreg:QI (plus:HI (reg:HI 28)
>                           (const_int 17)) 0))
>
> after elimination.
>
> Attached patch uses new pushhi1_insn to push virtuals in HImode so that
> expressions like in subreg_reg from above can be reloaded.
>
> Ok to commit ?
>
> Johann
>
>         PR target/64452
>
>         * config/avr/avr.md (pushhi_insn): New insn.
>         (push<mode>1): Push virtual regs in one chunk using pushhi1_insn.

Approved.
(But I'm worry about this because it's reload related problem and it
can have a side effect)

Denis.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]