This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Add option ftree-stdarg-opt


On Tue, Feb 17, 2015 at 1:12 PM, Tom de Vries <Tom_deVries@mentor.com> wrote:
> Hi,
>
> this patch adds option ftree-stdarg-opt, which switches pass_stdarg on or
> off.
>
> Pass_stdarg does an optimization on cfun->va_list_gpr/fpr_size, and since
> it's an optimization, it's useful to be able to switch it off in case of a
> problem with the pass.
>
> This is not a regression or documentation fix, so it doesn't classify as a
> stage 4 patch. I could imagine it still being included in stage4 because it
> adds the possibility for a workaround in case of problems.
>
> Bootstrapped and reg-tested on x86_64.
>
> OK for stage1 (or even stage 4)?

New options need to be documented in invoke.texi.  I also wonder
if 'stdarg' is a term known to programmers.  I'd rather document it
as
"Optimize the prologue of variadic argument functions with respect
to usage of those arguments"

And please omit 'tree' from the flag, thus -fstdarg-opt

Otherwise generally fine for stage4.

Thanks,
Richard.

> Thanks,
> - Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]