This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Haifa Scheduler] Fix latent bug in macro-fusion/instruction grouping

On 02/11/15 02:20, James Greenhalgh wrote:

On Mon, Feb 09, 2015 at 11:16:56PM +0000, Jeff Law wrote:
On 02/06/15 05:24, James Greenhalgh wrote:

2015-02-06  James Greenhalgh  <>

	* haifa-sched.c (recompute_todo_spec): After applying a
	replacement and cancelling a dependency, also clear the
My worry here would be that we might be clearing a SCHED_GROUP_P that
had been set for some reason other than macro-fusion.

Yeah, I also had this worry. This patch tackles the problem from the
other direction. If we see a SCHED_GROUP_P on an insn, treat it as a
hard dependency, and don't try to rewrite it. I think this will always
be "safe" but it might pessimize if the dependency breaker would have
resulted in better code generation.

I don't think this gives you anything towards fixing your bug, but
it clears mine.
Right. Mine was in the management of the ready queue. We allowed something with SCHED_GROUP_P to get deferred for several cycles. While it was deferred another insn that was previously deferred became ready and fired. That messed up the scheduling group and ultimately resulted in incorrect code.

The fix was actually pretty simple, We just queue the SCHED_GROUP_P for a single cycle, then reevaluate.

I've bootstrapped and tested on x86_64-unknown-linux-gnu with no
issues and given it a quick check on the problem code from before,
where it has the desired impact.


2015-02-10  James Greenhalgh  <>

	* haifa-sched.c (recompute_todo_spec): Treat SCHED_GROUP_P
	as forcing a HARD_DEP between instructions, thereby
	disallowing rewriting to break dependencies.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]