This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [testsuite] PATCH: Add check_effective_target_pie
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Jeff Law <law at redhat dot com>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, Magnus Granberg <zorry at gentoo dot org>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 11 Feb 2015 00:11:00 +0100
- Subject: Re: [testsuite] PATCH: Add check_effective_target_pie
- Authentication-results: sourceware.org; auth=none
- References: <20150111235837 dot GA26961 at gmail dot com> <54B42880 dot 2040800 at redhat dot com> <CAMe9rOq4mS7MtgrfLAKg2htp99rbZVcY8enGGiVSU5c9xG+3eQ at mail dot gmail dot com> <2219602 dot BYtQkL3Scp at laptop1 dot gw dot ume dot nu> <54B444E4 dot 1080700 at redhat dot com> <20150113125201 dot GA18558 at gmail dot com> <54B570D5 dot 4040008 at redhat dot com>
Jeff Law <law@redhat.com> writes:
>> Subject: [PATCH 1/5] Add check_effective_target_pie
>>
>> Hi,
>>
>> This patch adds check_effective_target_pie to check if the current
>> multilib generates PIE by default.
>>
>> Thanks.
>>
>> H.J.
>> ---
>> 2015-01-11 H.J. Lu <hongjiu.lu@intel.com>
>>
>> * gcc.target/i386/pie.c: New test.
>>
>> * lib/target-supports.exp (check_effective_target_pie): New.
> OK.
The new proc is bogus, unfortunately: there's already an existing
check_effective_target_pie that checks if a target can support PIE. The
new one just overrides the previous one. On targets supporting PIE
(like Darwin), but not defaulting to it, the PIE tests suddenly turn out
UNSUPPORTED.
You should rename the new one to
e.g. check_effective_target_pie_default, update the single user, and
document it in sourcebuild.texi.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University