This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][AArch64] Testcase fix for __ATOMIC_CONSUME
- From: Mike Stump <mikestump at comcast dot net>
- To: Alex Velenko <Alex dot Velenko at arm dot com>
- Cc: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Marcus Shawcroft <marcus dot shawcroft at arm dot com>
- Date: Mon, 9 Feb 2015 09:10:17 -0800
- Subject: Re: [PATCH][AArch64] Testcase fix for __ATOMIC_CONSUME
- Authentication-results: sourceware.org; auth=none
- References: <1422375847-18680-1-git-send-email-alex dot velenko at arm dot com> <A97E3995-549C-4A0B-B6A3-1207917FCC8F at comcast dot net> <CAFqB+PyB_qHHLmzzmx9QVsRkaS8JKYOzYwiZP2D0qxrXDa=uDw at mail dot gmail dot com> <58101C4C-374A-43E5-B255-C97CE3046A2C at comcast dot net> <54D8CE31 dot 6090503 at arm dot com>
On Feb 9, 2015, at 7:11 AM, Alex Velenko <Alex.Velenko@arm.com> wrote:
> The following patch makes atomic-op-consume.c XFAIL
>
> Is this patch ok?
Ok.
I’d shorten the comment above the xfail to be exceedingly short:
/* PR59448 consume not implemented yet */
The reason is the brain can process this about 8x faster. Also, one can cut and paste the PR part into a web browser directly, or, if you have an electric bugzilla mode for emacs, it will pop right up. */