This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][libstdc++][Testsuite] isctype test fails for newlib.
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Matthew Wahab <matthew dot wahab at arm dot com>
- Cc: Jonathan Wakely <jwakely dot gcc at gmail dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, libstdc++ <libstdc++ at gcc dot gnu dot org>, hp at gcc dot gnu dot org
- Date: Mon, 9 Feb 2015 08:18:23 -0500 (EST)
- Subject: Re: [PATCH][libstdc++][Testsuite] isctype test fails for newlib.
- Authentication-results: sourceware.org; auth=none
- References: <54CF9C84 dot 4020706 at arm dot com> <54CFA31F dot 9020601 at oracle dot com> <CAH6eHdQNytx0NCcZEPUBorenk+f=8BE86BSGiJ7=FpXZFYuL3A at mail dot gmail dot com> <54D0A034 dot 1040306 at arm dot com> <54D0A291 dot 4010702 at oracle dot com> <54D0A5B1 dot 2000806 at arm dot com> <CAH6eHdT2O7rqKPG+auYPPeRmEZsorteub3vgazHpnti3DVdapQ at mail dot gmail dot com> <54D8992B dot 6060707 at arm dot com>
On Mon, 9 Feb 2015, Matthew Wahab wrote:
> On 07/02/15 00:11, Jonathan Wakely wrote:
> > Any idea why HP still sees the tests fail? See comment 8 at
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64467#c8
>
> It looks like he's found the problem: that _NEWLIB_ is a recent addition that
> isn't in the version he's using. I'll try replacing _NEWLIB_ with
> _NEWLIB_VERSION_ as suggested.
(Careful with that macro spelling, if nothing else.)
Better to use existing mechanisms and stop playing with
target-related macros. Add this at the top (see other
placements of dg-options) and replace "#if defined (__NEWLIB__)"
with "#ifdef NEWLINE_IN_CLASS_BLANK":
// { dg-options "-DNEWLINE_IN_CLASS_BLANK" { target newlib } }
brgds, H-P