This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR rtl-optimization/64905: Clear hard frame pointer alignment if not needed


Hello!

>>> When hard frame pointer isn't needed, the register for hard frame pointer
>>> may be reused.  This patch clears alignment on hard frame pointer if hard
>>> frame pointer isn't needed.  OK for trunk after bootstrap and test on
>>> Linux/x86-64?
>>
>> LRA can set up frame_pointer_needed in some complicated cases (in
>> lra-eliminations.c::setup_can_eliminate).  So I'd reset REGNO_POINTER_ALIGN
>> in setup_can_eleminate for any case even although without the change the
>> patch is safe.
>>
>> So, H.J., if you add resetting REGNO_POINTER_ALIGN in setup_can_eliminate,
>> the patch is automatically approved.
>
> This is what I checked in.

Attached patch disables the test on -fPIC targets, explicitly passes
-fomit-frame-pointer and removes unneeded main for a compile test.

2015-02-05  Uros Bizjak  <ubizjak@gmail.com>

        PR rtl-optimization/64905
        * gcc.target/i386/pr64905.c: Require nonpic target.
        (dg-options): Add -fomit-frame-pointer.
        (main): Remove.

Tested on x86_64-linux-gnu and committed to mainline SVN.

Uros.

Attachment: t.diff.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]