This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Work around Firefox -fprofile-generate crash


On Thu, Feb 05, 2015 at 08:20:20AM +0100, Richard Biener wrote:
> On February 5, 2015 12:28:14 AM CET, Jan Hubicka <hubicka@ucw.cz> wrote:
> >Hi,
> >this patch avoids ICE in programs that uses multiple copies of libgcov
> >at once.
> >It is just a temporary workaround as discussed in the PR log.
> >
> >Tested on Firefox and comitted.
> 
> I expect this will break on platforms with default -fno-common?

Well, that can be handled by adding
__attribute__((common)) if IN_LIBGCOV, the library is always built with gcc,
isn't it?  That said, it still won't help if version script makes it
private, and the size of the structure becomes ABI matter.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]