This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [AArch64] Rid the world of NAMED_PARAM


On 4 February 2015 at 12:06, James Greenhalgh <james.greenhalgh@arm.com> wrote:
>
> Hi,
>
> HAVE_DESIGNATED_INITIALIZERS is not set for C++, so the NAMED_PARAM macros
> using it provide false security when we compile aarch64.c. Removing this
> is an obvious cleanup and gets rid of some confusing dead code.
>
> This patch removes all the magic macros.
>
> Bootstrapped and tested on aarch64-none-linux-gnu with no issues.
>
> I can't see anyone objecting to this and would normally commit it
> as obvious, but as we are in Stage 4, I'll ask for permission.
>
> So OK for trunk/Stage 1?
>
> Thanks,
> James
>
> ---
> 2015-02-04  James Greenhalgh <james.greenhalgh@arm.com>
>
>         * config/aarch64/aarch64.c (NAMED_PARAM): Delete it.
>         (generic_addrcost_table): Remove NAMED_PARAM.
>         (cortexa57_addrcost_table): Likewise.
>         (xgene1_addrcost_table): Likewise.
>         (generic_regmove_table): Likewise.
>         (cortexa53_regmove_table): Likewise.
>         (xgene1_regmove_table): Likewise.
>         (generic_vector_table): Likewise.
>         (cortexa57_vector_table): Likewise.
>         (xgene1_vector_table): Likewise.
>         (generic_tunings): Likewise.
>         (cortexa53_tunings): Likewise.
>         (cortexa57_tunings): Likewise.
>         (xgene1_tunings): Likewise.


This is pure churn, no functional change. I'd rather take this now in
stage than defer to stage 1.  Taking it now will mean less back port
pain next year. OK /Marcus


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]