This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch ARM] Improve guality tests - part 1 - pr36728-1.c
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, "segher at gcc dot gnu dot org" <segher at gcc dot gnu dot org>
- Date: Wed, 4 Feb 2015 12:40:55 +0100
- Subject: Re: [Patch ARM] Improve guality tests - part 1 - pr36728-1.c
- Authentication-results: sourceware.org; auth=none
- References: <54D1EF49 dot 5080809 at arm dot com> <CAJA7tRa-qEwkLE1tGZ=5w2agJuaUHj5OmKaPiz0Yyq7LuVvX-g at mail dot gmail dot com> <20150204111019 dot GN1746 at tucnak dot redhat dot com> <54D2037F dot 6030404 at arm dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Feb 04, 2015 at 11:33:19AM +0000, Ramana Radhakrishnan wrote:
> --- a/gcc/testsuite/gcc.dg/guality/pr36728-1.c
> +++ b/gcc/testsuite/gcc.dg/guality/pr36728-1.c
> @@ -49,5 +49,6 @@ main ()
> int l = 0;
> asm ("" : "=r" (l) : "0" (l));
> a = foo (l + 1, l + 2, l + 3, l + 4, l + 5, l + 6, l + 30);
> + asm volatile ( "" : : "r" (l));
Please remove the space before "".
> --- a/gcc/testsuite/gcc.dg/guality/pr36728-2.c
> +++ b/gcc/testsuite/gcc.dg/guality/pr36728-2.c
> @@ -49,5 +49,6 @@ main ()
> int l = 0;
> asm ("" : "=r" (l) : "0" (l));
> a = foo (l + 1, l + 2, l + 3, l + 4, l + 5, l + 6, l + 30);
> + asm ("" : : "r" (l));
Please add volatile, and remove the extra space in between : :
> --- a/gcc/testsuite/gcc.dg/guality/pr36728-3.c
> +++ b/gcc/testsuite/gcc.dg/guality/pr36728-3.c
> @@ -47,5 +47,6 @@ main ()
> int l = 0;
> asm volatile ("" : "=r" (l) : "0" (l));
> foo (l + 1, l + 2, l + 3, l + 4, l + 5, l + 6, l + 30);
> + asm volatile ( "" : : "r" (l));
See the 1st comment.
> --- a/gcc/testsuite/gcc.dg/guality/pr36728-4.c
> +++ b/gcc/testsuite/gcc.dg/guality/pr36728-4.c
> @@ -47,5 +47,6 @@ main ()
> int l = 0;
> asm volatile ("" : "=r" (l) : "0" (l));
> foo (l + 1, l + 2, l + 3, l + 4, l + 5, l + 6, l + 30);
> + asm volatile ( "" : "r" (l));
Likewise. Also one : is missing, wonder how this could compile.
Jakub