This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][libstdc++][Testsuite] isctype test fails for newlib.

On 03/02/15 10:27, Paolo Carlini wrote:
Nit: the path should be * testsuite/28_regex/... and likewise for the
other testcase, because it starts where is the corresponding ChangeLog.

Fixed changelog:

2015-02-02  Matthew Wahab  <>

	PR libstdc++/64467
	* testsuite/28_regex/traits/char/ (test01): Add newlib
	special case for '\n'.
	* testsuite/28_regex/traits/wchar_t/ (test01): Likewise.

Ok to commit?
diff --git a/libstdc++-v3/testsuite/28_regex/traits/char/ b/libstdc++-v3/testsuite/28_regex/traits/char/
index a7b1396..7c47045 100644
--- a/libstdc++-v3/testsuite/28_regex/traits/char/
+++ b/libstdc++-v3/testsuite/28_regex/traits/char/
@@ -53,7 +53,13 @@ test01()
   VERIFY(!t.isctype('_', t.lookup_classname(range(digit))));
   VERIFY( t.isctype(' ', t.lookup_classname(range(blank))));
   VERIFY( t.isctype('\t', t.lookup_classname(range(blank))));
+#if defined (__NEWLIB__)
+  /* newlib includes '\n' in class 'blank'.
+     See  */
+  VERIFY( t.isctype('\n', t.lookup_classname(range(blank))));
   VERIFY(!t.isctype('\n', t.lookup_classname(range(blank))));
   VERIFY( t.isctype('t', t.lookup_classname(range(upper), true)));
   VERIFY( t.isctype('T', t.lookup_classname(range(lower), true)));
 #undef range
diff --git a/libstdc++-v3/testsuite/28_regex/traits/wchar_t/ b/libstdc++-v3/testsuite/28_regex/traits/wchar_t/
index e450f6d..1b3d69a 100644
--- a/libstdc++-v3/testsuite/28_regex/traits/wchar_t/
+++ b/libstdc++-v3/testsuite/28_regex/traits/wchar_t/
@@ -50,7 +50,13 @@ test01()
   VERIFY(!t.isctype(L'_', t.lookup_classname(range(digit))));
   VERIFY( t.isctype(L' ', t.lookup_classname(range(blank))));
   VERIFY( t.isctype(L'\t', t.lookup_classname(range(blank))));
+#if defined (__NEWLIB__)
+  /* newlib includes '\n' in class 'blank'.
+     See  */
+  VERIFY( t.isctype(L'\n', t.lookup_classname(range(blank))));
   VERIFY(!t.isctype(L'\n', t.lookup_classname(range(blank))));
   VERIFY( t.isctype(L't', t.lookup_classname(range(upper), true)));
   VERIFY( t.isctype(L'T', t.lookup_classname(range(lower), true)));
 #undef range

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]