This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][libstdc++][Testsuite] isctype test fails for newlib.


Hi,

On 02/02/2015 04:49 PM, Matthew Wahab wrote:
Hello,

With target arm-none-eabi, the libstdc++ tests 28_regex/traits/char/isctype.cc and 28_regex/traits/wchar/isctype.cc fail at
--
VERIFY(!t.isctype('\n', t.lookup_classname(range(blank))));
--
This is because libstdc++ puts '\n' in the 'space' character class, rather than 'blank' when building on newlib. This problem was known when suport for the blank character class was added to libstdc++ (see https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01902.html) so this failure is not unexpected.

Changes to newlib that would have allowed the problem to be fixed were made (https://sourceware.org/ml/newlib/2009/msg00342.html) but then reverted (https://sourceware.org/ml/newlib/2009/msg00438.html).

This patch modifies the test to add a special case for the behaviour with newlib.

Tested by running check-target-libstdc++-v3 - libstdc++-dg/conformance.exp, with the modified tests, for arm-none-eabi and aarch64-none-linux-gnu. No new failures and the modified tests now pass on arm-none-eabi.

Ok for trunk?
I guess the patch is Ok for trunk, but please also add in the comment a link to this message of yours, that is https://gcc.gnu.org/ml/gcc-patches/2015-02/msg00059.html.

Thanks,
Paolo.

PS: please remember to always CC libstdc++-v3 patches to libstdc++@gcc.gnu.org.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]