This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [[ARM/AArch64][testsuite] 03/36] Add vmax, vmin, vhadd, vhsub and vrhadd tests.


>>>> 2015-01-25  Christophe Lyon  <christophe.lyon@linaro.org>
>>>>
>>>> * gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h
>>>> (_ARM_FPSRC): Add DN and AHP fields.
>>>> (clean_results): Force DN=1 on AArch64.
>>>> * gcc.target/aarch64/advsimd-intrinsics/binary_op_no64.inc: New file.
>>>> * gcc.target/aarch64/advsimd-intrinsics/vhadd.c: New file.
>>>> * gcc.target/aarch64/advsimd-intrinsics/vhsub.c: New file.
>>>> * gcc.target/aarch64/advsimd-intrinsics/vmax.c: New file.
>>>> * gcc.target/aarch64/advsimd-intrinsics/vmin.c: New file.
>>>> * gcc.target/aarch64/advsimd-intrinsics/vrhadd.c: New file.
>>>>
>>>
>>> I guess you don't need the fake dependency fix for this as this is mostly
>>> called only once?
>>>
>> Yes, that is my current assumption: for the time being there is no
>> other code which can potentially change this value.
>>
>>> +  _ARM_FPSCR _afpscr_for_dn;
>>> +  asm volatile ("mrs %0,fpcr" : "=r" (_afpscr_for_dn));
>>> +  _afpscr_for_dn.b.DN = 1;
>>> +  asm volatile ("msr fpcr,%0" : : "r" (_afpscr_for_dn));
>>
>> Maybe in the future we'll want to check that DN=0 means that we
>> actually forward a NaN != DefaultNaN, but that can be a further
>> improvement to this patch.
>>
> Marcus,
> Is it OK to commit this one?
> This is the only remaining one from this series.

Yep, that's ok /Marcus


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]