This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [[ARM/AArch64][testsuite] 03/36] Add vmax, vmin, vhadd, vhsub and vrhadd tests.
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Christophe Lyon <christophe dot lyon at linaro dot org>
- Cc: Tejas Belagod <tejas dot belagod at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 2 Feb 2015 15:38:23 +0000
- Subject: Re: [[ARM/AArch64][testsuite] 03/36] Add vmax, vmin, vhadd, vhsub and vrhadd tests.
- Authentication-results: sourceware.org; auth=none
- References: <1421162314-25779-1-git-send-email-christophe dot lyon at linaro dot org> <CAKdteOZ82-XzrFcZWB8ajwF4V=8RE80k5ZkQ9EwWsPGt==zSqg at mail dot gmail dot com> <CAFqB+PxeynEFAdLWcrVDDhBC4Enzkijxc-V0V3jBOfhctWcPOQ at mail dot gmail dot com> <CAKdteOaraEWDsw4QTrz=jdnnq06i7D1GRx_+Uq2wR5gcDwTBfA at mail dot gmail dot com> <CAFqB+PwLtbMbuCXhP7B0TFwawQ8N4jR-mBVstyQsd5sT3_ZJtw at mail dot gmail dot com> <CAKdteOYU5DG3R+PEWv_z3D139VvW_7mUx1M-=rNv0HyBag0sSQ at mail dot gmail dot com> <CAFqB+PzgwEnzMW2F-1n2cyyYeMPxUxiebkp0sKBAWaKHHX7_oA at mail dot gmail dot com> <CAKdteOanm5jKNHiO-QBFhK_q19LGA8h28a+018xS-Dxj+YiZdQ at mail dot gmail dot com> <54C0DCD1 dot 7080502 at arm dot com> <CAKdteOYHHe=ALfe=fRBNOFFp3JoryEyWpnTrMK9kwNW77tgPCQ at mail dot gmail dot com> <54C1159B dot 20002 at arm dot com> <CAKdteOYYpNr-YsLvRuwfP+HOxPf5XV58vUAi7aLzQ=EJPWKikg at mail dot gmail dot com> <54C22012 dot 1070101 at arm dot com> <CAKdteOZVHFYWuS0UGS1kAMMOHrxdss57s9GXBqqtzwA2RHr9bg at mail dot gmail dot com> <CAKdteObUHZKhax5VsXzTCY3rODCvYerrprxVJ+BQYaSd-y2mSA at mail dot gmail dot com> <CAKdteObyBRRiYN9PSxwKUhm7iKQycTLsynFiviAu5txx3dDhOg at mail dot gmail dot com> <54C62EC7 dot 2030702 at arm dot com> <CAKdteOZptDhdcAemYdCniqXUvWs1vu7BRNmJftgAQZ0YSNxKQw at mail dot gmail dot com> <CAKdteOZ4QzShm74a4=bkKAadr_gAhu5P4Gx+EY08vVT2P=P1bQ at mail dot gmail dot com>
>>>> 2015-01-25 Christophe Lyon <christophe.lyon@linaro.org>
>>>>
>>>> * gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h
>>>> (_ARM_FPSRC): Add DN and AHP fields.
>>>> (clean_results): Force DN=1 on AArch64.
>>>> * gcc.target/aarch64/advsimd-intrinsics/binary_op_no64.inc: New file.
>>>> * gcc.target/aarch64/advsimd-intrinsics/vhadd.c: New file.
>>>> * gcc.target/aarch64/advsimd-intrinsics/vhsub.c: New file.
>>>> * gcc.target/aarch64/advsimd-intrinsics/vmax.c: New file.
>>>> * gcc.target/aarch64/advsimd-intrinsics/vmin.c: New file.
>>>> * gcc.target/aarch64/advsimd-intrinsics/vrhadd.c: New file.
>>>>
>>>
>>> I guess you don't need the fake dependency fix for this as this is mostly
>>> called only once?
>>>
>> Yes, that is my current assumption: for the time being there is no
>> other code which can potentially change this value.
>>
>>> + _ARM_FPSCR _afpscr_for_dn;
>>> + asm volatile ("mrs %0,fpcr" : "=r" (_afpscr_for_dn));
>>> + _afpscr_for_dn.b.DN = 1;
>>> + asm volatile ("msr fpcr,%0" : : "r" (_afpscr_for_dn));
>>
>> Maybe in the future we'll want to check that DN=0 means that we
>> actually forward a NaN != DefaultNaN, but that can be a further
>> improvement to this patch.
>>
> Marcus,
> Is it OK to commit this one?
> This is the only remaining one from this series.
Yep, that's ok /Marcus