Re: [PATCH][PR target/15184] Fix for direct byte access on x86

[Jeff Law <law at redhat dot com>]

On 01/30/15 03:07, Uros Bizjak wrote:
> On Fri, Jan 30, 2015 at 7:12 AM, Jeff Law <law@redhat.com> wrote:
>
> > > Hello!
> > >
> > > > So here's the updated patch which handles all 4 testcases from the PR as
> > > > well as a couple of my own.
> > >
> > >
> > > @@ -0,0 +1,33 @@
> > > +/* PR 15184 first two tests, plus two addition ones.  */
> > > +/* { dg-do compile } */
> > > +/* { dg-options "-O2 -m32 -march=pentiumpro" } */
> > >
> > > No, we don't want -m32 in dg-options. Please write this part as:
> > >
> > > /* { dg-do compile { target ia32 } } */
> > > /* { dg-options "-O2 -march=pentiumpro" } */
> >
> > Will update after sniff testing.  Sorry for the noise.
>
> I'll commit the attached patch that fixes this and -fpic problem as
> soon as regtest finishes.
>
> 2015-01-30  Uros Bizjak  <ubizjak@gmail.com>
>
>      * gcc.target/i386/pr15184-1.c: Compile for ia32 target only.
>      (dg-options): Remove -m32.
>      (dg-final): Scan for "movb %al" only.
>      * gcc.target/i386/pr15184-2.c: Ditto.
Again, sorry for making work for you.  There's clearly more to the x86 
target tests than meets the eye.  I'll run further additions through you 
until I think I've got my brain wrapped around all things that have to 
be considered for x86 specific tests.

jeff