This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, c] PR c/48956: diagnostics for conversions involving complex types
- From: Mikhail Maltsev <maltsevm at gmail dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 30 Jan 2015 10:38:41 +0300
- Subject: Re: [PATCH, c] PR c/48956: diagnostics for conversions involving complex types
- Authentication-results: sourceware.org; auth=none
- References: <20141229174555 dot 79e9defd at debian-miyuki> <alpine dot DEB dot 2 dot 10 dot 1501300010300 dot 14904 at digraph dot polyomino dot org dot uk>
On Fri, 30 Jan 2015 00:15:02 +0000
Joseph Myers <joseph@codesourcery.com> wrote:
> > +#if 0
> > + /* Check needs to be implemented. */
> > + fuic (-1. + 0.i);
> > + vuic = -1. + 0.i;
> > +#endif
>
> The #if 0 cases should have a bug filed in Bugzilla to track that
> certain checks aren't implemented.
Thanks for review. Just one question: should I change the cases under
#if 0 to XFAIL (after adding a new bug to Bugzilla) or remove them
completely?
> The patch is OK for GCC 6 with the above fix and such a bug filed,
> once the copyright assignment is in place. (Once GCC 5 has branched
> and the assignment is done, please retest and send a patch with the
> testcase fix to gcc-patches with a request for someone to commit it.)
OK. I hope FSF will receive my copyright assignment soon (according to
USPS post tracking it's already delivered).
--
Regards,
Mikhail Maltsev