This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][PR target/15184] Fix for direct byte access on x86
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Jeff Law <law at redhat dot com>
- Date: Thu, 29 Jan 2015 15:54:34 +0100
- Subject: Re: [PATCH][PR target/15184] Fix for direct byte access on x86
- Authentication-results: sourceware.org; auth=none
- References: <CAFULd4ZrCea=qSn_bKGVytZHo7KUwPynGE4-RB9QnHe3k4RRvA at mail dot gmail dot com> <20150129144710 dot GJ1746 at tucnak dot redhat dot com>
On Thu, Jan 29, 2015 at 3:47 PM, Jakub Jelinek <jakub@redhat.com> wrote:
>> > So here's the updated patch which handles all 4 testcases from the PR as well as a couple of my own.
>>
>> @@ -0,0 +1,33 @@
>> +/* PR 15184 first two tests, plus two addition ones. */
>> +/* { dg-do compile } */
>> +/* { dg-options "-O2 -m32 -march=pentiumpro" } */
>>
>> No, we don't want -m32 in dg-options. Please write this part as:
>>
>> /* { dg-do compile { target ia32 } } */
>> /* { dg-options "-O2 -march=pentiumpro" } */
>
> Or
> /* { dg-do compile } */
> /* { dg-options "-O2" } */
> /* { dg-additional-options "-march=pentiumpro" { target ia32 } } */
> if there is nothing ia32 specific on the testcase, just that you want
> to use that -march option if you are compiling it as 32-bit.
In this case, you will need to add -mregparm=3 to
dg-additional-options to avoid "attribute ... ignored" awarning. There
are some examples in dg.target/i386/ testsuite directory.
Uros.