This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR64635 - load libgomp-plugin-host_nonshm shared library with correct suffix
- From: Jack Howarth <howarth dot at dot gcc at gmail dot com>
- To: Mike Stump <mikestump at comcast dot net>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Thomas Schwinge <thomas at codesourcery dot com>, Jakub Jelinek <jakub at redhat dot com>
- Date: Wed, 28 Jan 2015 16:43:19 -0500
- Subject: Re: [PATCH] PR64635 - load libgomp-plugin-host_nonshm shared library with correct suffix
- Authentication-results: sourceware.org; auth=none
- References: <CAJMcOU8YOGrW_WS9SouuR9H3VKxS1LCnomEZSUPP+iLNGj3oyQ at mail dot gmail dot com> <20150128210314 dot GC1746 at tucnak dot redhat dot com> <0109719F-3218-409C-BADB-41119836039B at comcast dot net>
Mike,
Thanks for the commit. There is one other issue that I have been
pondering about filing a PR. In fink and MacPorts, FSF gcc is built
and packaged using either...
--prefix=/sw/lib/gcc5.0
or
--libdir=/opt/local/lib/gcc5
such that the libraries for each gcc release are buried. While this
doesn't present an issue in running the libgomp test suite when
-DACC_DEVICE_TYPE_host_nonshm=1 is used, end-users will have to
explicitly set DYLD_LIBRARY_PATH to contain /sw/lib/gcc5.0/lib or
/opt/local/lib/gcc5 for such executables to find the
libgomp-plugin-host_nonshm shared library.
I realize this is a corner case, but shouldn't libgomp/target.c
contain a hard-coded path from the build for the location of the
installed gcc libraries and make an initial attempt to open it from
that location before attempting a second time without an explicit
path? Any thoughts?
Jack
On Wed, Jan 28, 2015 at 4:22 PM, Mike Stump <mikestump@comcast.net> wrote:
> On Jan 28, 2015, at 1:03 PM, Jakub Jelinek <jakub@redhat.com> wrote:
>> Please add
>> PR libgomp/64635
>> to the ChangeLog entry.
>> Ok with that change.
>
> Committed revision 220218.