Re: Merge current set of OpenACC changes from gomp-4_0-branch

[Thomas Schwinge <thomas at codesourcery dot com>]

Hi!

Sorry for the late answer -- I've been on sick leave, and just now
returning to work.  Julian, would you please have a look at the following
issues?

> > > In r219682, I have committed to trunk our current set of OpenACC changes,
> > > which we had prepared on gomp-4_0-branch.  Thanks to everyone who has
> > > been contributing!

On Fri, 23 Jan 2015 20:20:53 +0300, Ilya Verbin <iverbin@gmail.com> wrote:
> On 17 Jan 02:16, Ilya Verbin wrote:
> > Unfortunately, it broke offloading from shared libraries (I mean common libs
> > with NEEDED entries, not dlopened).

Sorry for that!

> > Such things are not covered by the
> > testsuite, that's why you missed this issue.  Here is a simple testcase:

<http://news.gmane.org/find-root.php?message_id=%3C20150116231632.GB48380%40msticlxl57.ims.intel.com%3E>

Probably a good motivation for adding such a test case.  ;-)

> > So, you don't assume that a device can have multiple images from multiple libs?
> 
> Ping?

This probably is "just" a bug that we introduced with our changes?
(Julian?)


> Also, could you please explain, why did you divide a device initialization into
> two functions -- gomp_init_device and gomp_init_tables?

As I understand it (again, Julian, please correct me if I got that
wrong), the reason is that for OpenACC support, we need these as two
separate (independent) actions.  Is this causing problems for OpenMP
offloading?


> Currently I'm trying to rebase on trunk my old patch, which fixes offloading
> from dlopened libraries: http://gcc.gnu.org/ml/gcc-patches/2014-11/msg01604.html
> It works for OpenMP and MIC, but I don't know how not to break OpenACC and PTX.


GrÃÃe,
 Thomas

Attachment: pgpOpQvqHseGP.pgp
Description: PGP signature