This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Update BBs in cleanup_barriers pass (PR rtl-optimization/61058)
- From: Eric Botcazou <ebotcazou at adacore dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 26 Jan 2015 10:06:05 +0100
- Subject: Re: [PATCH] Update BBs in cleanup_barriers pass (PR rtl-optimization/61058)
- Authentication-results: sourceware.org; auth=none
- References: <20150122204317 dot GM1746 at tucnak dot redhat dot com>
> While the cleanup_barriers runs after cleaning up BLOCK_FOR_INSNs,
> some targets like i?86/x86_64 choose to populate it again during machine
> reorg and some target don't free it at the end of machine reorg.
> This patch updates cleanup_barrier pass, so that it adjusts basic block
> boundaries and BLOCK_FOR_INSNs in that case, so that we don't crash during
> final pass.
This isn't a recent regression so what about fixing it more "properly"? For
example, by calling free_bb_for_insn at the end of the machinre reorg passes
which called compute_bb_for_insn at the beginning? Or do the affected ports
need the BB info all the way down to final?
--
Eric Botcazou