This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, i386] Remove EBX usage from asm code
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Rainer Orth <ro at cebitec dot uni-bielefeld dot de>, Richard Biener <rguenther at suse dot de>, Evgeny Stupachenko <evstupac at gmail dot com>
- Date: Fri, 23 Jan 2015 20:48:08 +0100
- Subject: Re: [PATCH, i386] Remove EBX usage from asm code
- Authentication-results: sourceware.org; auth=none
- References: <CAOvf_xxRWG-rskfXsgwqTV=DhzPiBrR+2J1QFfH-+eA1BiL_4A at mail dot gmail dot com> <yddwq4lpha9 dot fsf at CeBiTec dot Uni-Bielefeld dot DE> <CAFULd4Yo0qaU16AFCaDhLu6gg4AVoh3Z18boDsf8BAJH=pPzzw at mail dot gmail dot com> <yddsif9p84i dot fsf at CeBiTec dot Uni-Bielefeld dot DE> <CAFULd4Y6tT5sBD1H9zoAg7M6tG5Hc9z0=ZPFDLTKLKJgN2mgzQ at mail dot gmail dot com> <yddvbk1okjb dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE> <CAFULd4ZH-tSezjhJHhOksLqiRhwPTvihBuAQjibHTq4PThnw9A at mail dot gmail dot com> <20150120095833 dot GB1746 at tucnak dot redhat dot com> <CAFULd4bACGP0MrWjp+AaLOLUKsStpnSCeCYUMmcNTj1Yqt7YCw at mail dot gmail dot com> <20150123120431 dot GQ1746 at tucnak dot redhat dot com> <CAFULd4aBy8JVxDOBsiiA+gHrkdPJb09wdooopZb3BOwKHXzH7A at mail dot gmail dot com>
On Fri, Jan 23, 2015 at 1:08 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
>>> I'm testing the attached patch that moves the definition to libgcc
>>> *and* wraps it in __i386__ to fix multilibs. Rainer, can you please
>>> implement the fix for the Solaris/x86, presumably in the same way?
>>>
>>> libgcc/ChangeLog:
>>>
>>> 2015-23-01 Uros Bizjak <ubizjak@gmail.com>
>>>
>>> * config/i386/gnu-user-lib.h New file.
>>
>> Missing semicolon.
>> I'd argue that there is nothing GNU related in it though, _GLOBAL_OFFSET_TABLE_
>> is a general ELF thing, so perhaps elf-lib.h instead?
>
> Yes, the name is better. It would also fit with Solaris.
Bootstrap and regression test was OK.
Committed with following ChangeLogs:
libgcc/ChangeLog:
2015-01-23 Uros Bizjak <ubizjak@gmail.com>
* config/i386/elf-lib.h: New file.
(CRT_GET_RFIB_DATA): Move definition from gcc/config/i386/gnu-user.h.
Wrap definition in #ifdef __i386__.
* libgcc/config.host (i[34567]86-*-linux*, i[34567]86-*-kfreebsd*-gnu)
(i[34567]86-*-knetbsd*-gnu, i[34567]86-*-gnu*)
(i[34567]86-*-kopensolaris*-gnu, x86_64-*-linux*)
(x86_64-*-kfreebsd*-gnu, x86_64-*-knetbsd*-gnu): Add i386/elf-lib.h
to tm_file.
gcc/ChangeLog:
2015-01-23 Uros Bizjak <ubizjak@gmail.com>
* config/i386/gnu-user.h (CRT_GET_RFIB_DATA): Move definition to
libgcc/config/i386/elf-lib.h.
Uros.
- References:
- Re: [PATCH, i386] Remove EBX usage from asm code
- Re: [PATCH, i386] Remove EBX usage from asm code
- Re: [PATCH, i386] Remove EBX usage from asm code
- Re: [PATCH, i386] Remove EBX usage from asm code
- Re: [PATCH, i386] Remove EBX usage from asm code
- Re: [PATCH, i386] Remove EBX usage from asm code
- Re: [PATCH, i386] Remove EBX usage from asm code
- Re: [PATCH, i386] Remove EBX usage from asm code
- Re: [PATCH, i386] Remove EBX usage from asm code
- Re: [PATCH, i386] Remove EBX usage from asm code