This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, AArch64, Obvious] Fix PR64231.
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Mike Stump <mikestump at comcast dot net>
- Cc: Tejas Belagod <tejas dot belagod at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, jakub at gcc dot gnu dot org, Andrew Pinski <pinskia at gmail dot com>
- Date: Fri, 23 Jan 2015 18:15:56 +0100
- Subject: Re: [Patch, AArch64, Obvious] Fix PR64231.
- Authentication-results: sourceware.org; auth=none
- References: <54C22A71 dot 7050603 at arm dot com> <C5E18A6A-B864-4DE8-BE8A-3F45828CCB8E at comcast dot net>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Jan 23, 2015 at 08:48:43AM -0800, Mike Stump wrote:
> On Jan 23, 2015, at 3:03 AM, Tejas Belagod <tejas.belagod@arm.com> wrote:
> > This is an almost obvious patch to fix PR64231 as discovered by A. Pinksi and as proposed by Jakub.
>
> Kinda crappy code. The macro to use here should take the number of bits as an int, and wether the constant is signed or not.
>
> FITS (x, 32, UNSIGNED)
Except that the test is testing something different.
First of all, it is closer to FITS (x, 33, SIGNED), but
the details are different, the test as is (except for the bug on 32-bit
hosts) INTVAL (x) is in not in [ -4GB + 33, 4GB - 32 ] interval (inclusive).
Why it isn't exactly "not in [ -4GB, 4GB - 1 ]" or similar.
Jakub