This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, fortran] Fix PR 57023, packing for some array temporaries
- From: Thomas Koenig <tkoenig at netcologne dot de>
- To: Tobias Burnus <tobias dot burnus at physik dot fu-berlin dot de>, gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org
- Date: Wed, 21 Jan 2015 20:46:37 +0100
- Subject: Re: [patch, fortran] Fix PR 57023, packing for some array temporaries
- Authentication-results: sourceware.org; auth=none
- References: <20150121125515 dot GA27852 at physik dot fu-berlin dot de>
Hi Tobias,
> Thomas Koenig wrote:
>> This patch takes the approach that any array bound which
>> contains a dummy variable which is not INTENT(IN) may be
>> changed by the user, and that we cannot be assured that
>> it will not be changed.
>
> How about sym->attr.flavor == FL_PARAMETER? I am not sure
> whether they are handled before, but if not not you really
> should regard them as constant - even more than INTENT(IN).
The test only does further checking if the variable in question
is a dummy variable. It is not possible to have a dummy parameter,
so I think we are safe.
> Otherwise, the patch looks okay.
Committed to trunk, will commit to 4.9 and 4.8 after a few days.
Thanks for the review!
Thomas