This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Add <codecvt> and last pieces of C++11 std::lib
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 21 Jan 2015 16:17:41 +0000
- Subject: Re: [patch] Add <codecvt> and last pieces of C++11 std::lib
- Authentication-results: sourceware.org; auth=none
- References: <20150116233830 dot GJ3360 at redhat dot com> <20150119132717 dot GF3360 at redhat dot com> <20150120115932 dot GS3360 at redhat dot com> <CAMe9rOqZkmrQWFaqnd+NbAJe3vkYvomNr6u-kS1GhnNU8nU-MQ at mail dot gmail dot com> <20150120175231 dot GB3360 at redhat dot com>
On 20/01/15 17:52 +0000, Jonathan Wakely wrote:
On 20/01/15 09:02 -0800, H.J. Lu wrote:
On Linux/ia-32, I got
output is:
/tmp/ccApSqaQ.o: In function `facet<char>::facet()':^M
/export/gnu/import/git/gcc-test-x32/src-trunk/libstdc++-v3/testsuite/22_locale/ctype_byname/2.cc:29:
undefined reference to
`std::ctype_byname<char>::ctype_byname(std::__cxx11::basic_string<char,
std::char_traits<char>, std::allocator<char> > const&, unsigned
int)'^M
/tmp/ccApSqaQ.o: In function `facet<wchar_t>::facet()':^M
/export/gnu/import/git/gcc-test-x32/src-trunk/libstdc++-v3/testsuite/22_locale/ctype_byname/2.cc:29:
undefined reference to
`std::ctype_byname<wchar_t>::ctype_byname(std::__cxx11::basic_string<char,
std::char_traits<char>, std::allocator<char> > const&, unsigned
int)'^M
collect2: error: ld returned 1 exit status^M
FAIL: 22_locale/ctype_byname/2.cc (test for excess errors)
FAIL: libstdc++-abi/abi_check
I forgot that the mangled name for size_t depends on the target, so
the linker script needs [jm] instead of m. Patch coming soon ...
This fixes the new FAILs on i686.
Tested x86_64-linux and i686-linux, committed to trunk.
I expect the new symbols are going to cause a problem on Solaris as
they match more than one symbol version, so I'll fix that ASAP.
commit 0715599f0458f89fe6d9ce6268008b95b6d022e6
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Tue Jan 20 18:51:07 2015 +0000
* config/abi/pre/gnu.ver: Use [jmy] for size_t parameters.
diff --git a/libstdc++-v3/config/abi/pre/gnu.ver b/libstdc++-v3/config/abi/pre/gnu.ver
index 61024bd..9d06f7a 100644
--- a/libstdc++-v3/config/abi/pre/gnu.ver
+++ b/libstdc++-v3/config/abi/pre/gnu.ver
@@ -187,7 +187,7 @@ GLIBCXX_3.4 {
std::__num_base::_S_atoms_out;
std::__moneypunct_cache*;
std::__numpunct_cache*;
- std::__timepunct_cache*
+ std::__timepunct_cache*;
# __gnu_debug::_Error_formatter*
};
@@ -1150,7 +1150,7 @@ GLIBCXX_3.4.10 {
_ZNKSt4hashISsEclESs;
_ZNKSt4hashIeEclEe;
- _ZSt17__verify_groupingPKc[mj]RKSs;
+ _ZSt17__verify_groupingPKc[jmy]RKSs;
_ZNSt8__detail12__prime_listE;
_ZNSt3tr18__detail12__prime_listE;
@@ -1729,7 +1729,7 @@ GLIBCXX_3.4.21 {
_ZSt9use_facetINSt7__cxx118numpunct*;
_ZSt9use_facetINSt7__cxx118time_get*;
- _ZSt17__verify_groupingPKc[mj]RKNSt7__cxx1112basic_string*;
+ _ZSt17__verify_groupingPKc[jmy]RKNSt7__cxx1112basic_string*;
_ZNSt3_V214error_category*;
_ZNKSt3_V214error_category*;
@@ -1793,23 +1793,23 @@ GLIBCXX_3.4.21 {
_ZT[ISV]St25__codecvt_utf8_utf16_base*;
# new string ctors for _byname facets
- _ZNSt12ctype_bynameI[cw]EC[1-5]ERKSsm;
- _ZNSt14codecvt_bynameI[cw]c11__mbstate_tEC[1-5]ERKSsm;
- _ZNSt15messages_bynameI[cw]EC[1-5]ERKSsm;
- _ZNSt15numpunct_bynameI[cw]EC[1-5]ERKSsm;
- _ZNSt15time_get_bynameI[cw]St19istreambuf_iteratorI[cw]St11char_traitsI[cw]EEEC[1-5]ERKSsm;
- _ZNSt15time_put_bynameI[cw]St19ostreambuf_iteratorI[cw]St11char_traitsI[cw]EEEC[1-5]ERKSsm;
- _ZNSt17moneypunct_bynameI[cw]Lb0EEC[1-5]ERKSsm;
- _ZNSt17moneypunct_bynameI[cw]Lb1EEC[1-5]ERKSsm;
-
- _ZNSt12ctype_bynameI[cw]EC[1-5]ERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEm;
- _ZNSt14codecvt_bynameI[cw]c11__mbstate_tEC[1-5]ERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEm;
- _ZNSt15time_put_bynameI[cw]St19ostreambuf_iteratorI[cw]St11char_traitsI[cw]EEEC[1-5]ERKNSt7__cxx1112basic_stringIcS2_SaIcEEEm;
- _ZNSt7__cxx1115messages_bynameI[cw]EC[1-5]ERKNS_12basic_stringIcSt11char_traitsIcESaIcEEEm;
- _ZNSt7__cxx1115numpunct_bynameI[cw]EC[1-5]ERKNS_12basic_stringIcSt11char_traitsIcESaIcEEEm;
- _ZNSt7__cxx1115time_get_bynameI[cw]St19istreambuf_iteratorI[cw]St11char_traitsI[cw]EEEC[1-5]ERKNS_12basic_stringIcS3_SaIcEEEm;
- _ZNSt7__cxx1117moneypunct_bynameI[cw]Lb0EEC[1-5]ERKNS_12basic_stringIcSt11char_traitsIcESaIcEEEm;
- _ZNSt7__cxx1117moneypunct_bynameI[cw]Lb1EEC[1-5]ERKNS_12basic_stringIcSt11char_traitsIcESaIcEEEm;
+ _ZNSt12ctype_bynameI[cw]EC[1-5]ERKSs[jmy];
+ _ZNSt14codecvt_bynameI[cw]c11__mbstate_tEC[1-5]ERKSs[jmy];
+ _ZNSt15messages_bynameI[cw]EC[1-5]ERKSs[jmy];
+ _ZNSt15numpunct_bynameI[cw]EC[1-5]ERKSs[jmy];
+ _ZNSt15time_get_bynameI[cw]St19istreambuf_iteratorI[cw]St11char_traitsI[cw]EEEC[1-5]ERKSs[jmy];
+ _ZNSt15time_put_bynameI[cw]St19ostreambuf_iteratorI[cw]St11char_traitsI[cw]EEEC[1-5]ERKSs[jmy];
+ _ZNSt17moneypunct_bynameI[cw]Lb0EEC[1-5]ERKSs[jmy];
+ _ZNSt17moneypunct_bynameI[cw]Lb1EEC[1-5]ERKSs[jmy];
+
+ _ZNSt12ctype_bynameI[cw]EC[1-5]ERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE[jmy];
+ _ZNSt14codecvt_bynameI[cw]c11__mbstate_tEC[1-5]ERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE[jmy];
+ _ZNSt15time_put_bynameI[cw]St19ostreambuf_iteratorI[cw]St11char_traitsI[cw]EEEC[1-5]ERKNSt7__cxx1112basic_stringIcS2_SaIcEEE[jmy];
+ _ZNSt7__cxx1115messages_bynameI[cw]EC[1-5]ERKNS_12basic_stringIcSt11char_traitsIcESaIcEEE[jmy];
+ _ZNSt7__cxx1115numpunct_bynameI[cw]EC[1-5]ERKNS_12basic_stringIcSt11char_traitsIcESaIcEEE[jmy];
+ _ZNSt7__cxx1115time_get_bynameI[cw]St19istreambuf_iteratorI[cw]St11char_traitsI[cw]EEEC[1-5]ERKNS_12basic_stringIcS3_SaIcEEE[jmy];
+ _ZNSt7__cxx1117moneypunct_bynameI[cw]Lb0EEC[1-5]ERKNS_12basic_stringIcSt11char_traitsIcESaIcEEE[jmy];
+ _ZNSt7__cxx1117moneypunct_bynameI[cw]Lb1EEC[1-5]ERKNS_12basic_stringIcSt11char_traitsIcESaIcEEE[jmy];
} GLIBCXX_3.4.20;