This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Use static chain and libffi for Go closures

From: Uros Bizjak <ubizjak at gmail dot com>
To: Ian Lance Taylor <iant at golang dot org>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Richard Henderson <rth at redhat dot com>, "gofrontend-dev at googlegroups dot com" <gofrontend-dev at googlegroups dot com>
Date: Mon, 19 Jan 2015 19:11:50 +0100
Subject: Re: Use static chain and libffi for Go closures
Authentication-results: sourceware.org; auth=none
References: <CAFULd4Y9ySbKrk2GHnAa3breDj=81Sx74tDY8JaWxetS6WN+AQ at mail dot gmail dot com> <CAOyqgcU=8h-+hi8+RNdges6h5YHcjQw8r4GafdmagnpMoNLgsQ at mail dot gmail dot com> <CAFULd4YpwuuoVvSnhwPbs4XcWJGqsfW-d9sva3JC7pKgubPOPw at mail dot gmail dot com>

On Sat, Jan 17, 2015 at 7:34 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
> On Sat, Jan 17, 2015 at 12:19 AM, Ian Lance Taylor <iant@golang.org> wrote:
>
>>> You should also revert alpha specific change to
>>> libgo/go/testing/quick/quick_test.go, please see [1] and [2].
>>>
>>> [1] https://gcc.gnu.org/ml/gcc-patches/2013-03/msg00038.html
>>> [2] https://gcc.gnu.org/ml/gcc-patches/2013-03/msg00038/foo.patch
>>
>> Done like so.  Committed to mainline.
>
> Thanks!
>
> There is another part in runtime/go-ffi.c that looks like it is not
> necessary anymore with FFI_TARGET_HAS_COMPLEX_TYPE.

Attached is a more conservative v2 patch that conditionally enables
fixup code when FFI_TARGET_HAS_COMPLEX_TYPE is not defined.

Tested on x86_64-linux-gnu {-m32} without regressions.

Uros.

Attachment: g.diff.txt
Description: Text document

Follow-Ups:
- Re: Use static chain and libffi for Go closures
  - From: Richard Henderson

References:
- Re: Use static chain and libffi for Go closures
  - From: Uros Bizjak
- Re: Use static chain and libffi for Go closures
  - From: Ian Lance Taylor
- Re: Use static chain and libffi for Go closures
  - From: Uros Bizjak

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]