This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Ping] Port of VTV for Cygwin and MinGW
- From: Patrick Wollgast <patrick dot wollgast at rub dot de>
- To: Ian Lance Taylor <iant at google dot com>, Kai Tietz <ktietz70 at googlemail dot com>, "cmtice at google dot com >> Caroline Tice" <cmtice at google dot com>, bkoz at gnu dot org, "jwakely at redhat dot com >> Jonathan Wakely" <jwakely at redhat dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>
- Date: Thu, 15 Jan 2015 08:54:24 +0100
- Subject: Re: [Ping] Port of VTV for Cygwin and MinGW
- Authentication-results: sourceware.org; auth=none
- References: <53FF0C8C dot 8090507 at rub dot de> <5411213F dot 1070104 at rub dot de> <CABtf2+RU7frwOXOX2FF8Tmfc6ssrpfFVj1Vuue4cZt19FpSWtQ at mail dot gmail dot com> <CABtf2+QWxvv1FUW_-kD3d0FBhYQWkZcPWAx8ASies_4j7thmoA at mail dot gmail dot com> <541B5B7E dot 2090300 at rub dot de> <20140923102235 dot GJ2669 at redhat dot com> <542344CB dot 6050600 at rub dot de> <CAEwic4b+KWO3pWQN_sbXqyf2MNWdnN8ZpaUKBVY8ECSqhe0cYg at mail dot gmail dot com> <54369316 dot 7070001 at rub dot de> <CAEwic4bT+OBQcatruiZ5Cnv1d6YMGckuf4Auf9+WzKLchNNZEg at mail dot gmail dot com> <543F9BB8 dot 1040503 at rub dot de> <54524B43 dot 7000105 at rub dot de> <5463893D dot 50807 at rub dot de> <CAEwic4YwnLjJCLii=AdG_-RXEnS3=b1nK90FA5iEsd497aRn8g at mail dot gmail dot com> <54639CC5 dot 4050508 at rub dot de> <CAEwic4YUkQfCo+hZi5BrYyurWzZ7FxLBxaR=HL5TuBdB38ePuA at mail dot gmail dot com> <5476F20C dot 5010801 at rub dot de> <548876B5 dot 70306 at rub dot de> <54A99E34 dot 2010202 at rub dot de> <54AEE9B0 dot 3010407 at rub dot de> <CAKOQZ8wVtj_+e=Jax6mKc+Uq3FOeQzTZubejk-TDJBFhPhxABQ at mail dot gmail dot com> <54B6D159 dot 4000002 at rub dot de> <CAKOQZ8w9_5OJEfnWJ-rgBgVzOzQcEj984MQcp=R1w=0JLUU8mw at mail dot gmail dot com>
On 15.01.2015 00:52, Ian Lance Taylor wrote:
> On Wed, Jan 14, 2015 at 12:28 PM, Patrick Wollgast
> <patrick.wollgast@rub.de> wrote:
>> On 14.01.2015 20:00, Ian Lance Taylor wrote:
>>> On Thu, Jan 8, 2015 at 12:33 PM, Patrick Wollgast
>>> <patrick.wollgast@rub.de> wrote:
>>>> A short recap again:
>>>>
>>>> Latest patch, changelog and a test program (further information about
>>>> the program in the mail):
>>>> https://gcc.gnu.org/ml/gcc-patches/2014-11/msg03368.html
>>>
>>> In that patch, the change to varasm.c looks wrong if neither
>>> OBJECT_FORMAT_ELF nor TARGET_PECOFF are defined. It looks like you've
>>> dropped the switch_to_section call in that case.
>>>
>>> Ian
>>>
>>
>> You're right. It should have been '#else' again, instead of 'else'
>> before the switch_to_section call.
>
> OK, the patches to varasm.c and cp/vtable-class-hierarchy.c are OK.
>
> Thanks.
>
> Ian
>
Thanks to all the reviewers!
Is there something I'm still supposed to do, since I don't have write
access and this was the last part missing an "OK"?
Regards,
Patrick