This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix ICE with -fgnu-tm and pragma ivdep (PR middle-end/64391)

From: Jeff Law <law at redhat dot com>
To: Marek Polacek <polacek at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Tue, 13 Jan 2015 12:18:15 -0700
Subject: Re: [PATCH] Fix ICE with -fgnu-tm and pragma ivdep (PR middle-end/64391)
Authentication-results: sourceware.org; auth=none
References: <20150113162815 dot GE24628 at redhat dot com>

On 01/13/15 09:28, Marek Polacek wrote:

We ICE on this testcase, because the usage of #pragma GCC ivdep
pulls in the ANNOTATE internal functions which don't have underlying
fndecls, hence we segv on a NULL_TREE.  This patch makes get_attrs_for
be prepared for such a scenario.  The callers of get_attrs_for already
check for NULL_TREE.  I don't think internal fns can have transaction_*
attributes anyway.  While at it, I did some cleanups.

Bootstrapped/regtested on {ppc64,x86_64}-linux, ok for trunk?

2015-01-13  Marek Polacek  <polacek@redhat.com>

	PR middle-end/64391
	* trans-mem.c (get_attrs_for): Return NULL_TREE if X is NULL_TREE.

	* gcc.dg/tm/pr64391.c: New test.

OK. I looked briefly at perhaps catching this earlier in the callchain, but your approach looks best to me.


Thanks,
Jeff

References:
- [PATCH] Fix ICE with -fgnu-tm and pragma ivdep (PR middle-end/64391)
  - From: Marek Polacek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]