This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, aarch64] Add prefetch support
- From: "Dr. Philipp Tomsich" <philipp dot tomsich at theobroma-systems dot com>
- To: Andrew Pinski <pinskia at gmail dot com>
- Cc: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>, "Gopalasubramanian, Ganesh" <Ganesh dot Gopalasubramanian at amd dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 13 Jan 2015 15:32:23 +0100
- Subject: Re: [PATCH, aarch64] Add prefetch support
- Authentication-results: sourceware.org; auth=none
- References: <EB4625145972F94C9680D8CADD65161578E9323A at satlexdag04 dot amd dot com> <CAFqB+PzmnX6K203rpMmPJb6kY9aggX9-kkLgBUhkJoPTgWj5zg at mail dot gmail dot com> <CA+=Sn1n_wX3QULyp5+y62gO4D3mN-SR-j58SQrh+FDCOshyZZA at mail dot gmail dot com> <CAFqB+PzJsnWyDLrDgp_s1U8FO_B4BZL7BZFVuhFOPuiL10fz3A at mail dot gmail dot com> <CA+=Sn1k-qucM2fZLqQCtTh62i0jsKcvD8=3foCso0mE=J4s4tQ at mail dot gmail dot com>
Great. I should have an update patch-set ready & tested later tonight.
Best,
Phil.
> On 13 Jan 2015, at 15:18, Andrew Pinski <pinskia@gmail.com> wrote:
>
> On Tue, Jan 13, 2015 at 6:13 AM, Marcus Shawcroft
> <marcus.shawcroft@gmail.com> wrote:
>> On 11 January 2015 at 02:37, Andrew Pinski <pinskia@gmail.com> wrote:
>>> On Tue, Nov 11, 2014 at 6:47 AM, Marcus Shawcroft
>>> <marcus.shawcroft@gmail.com> wrote:
>>>> On 30 October 2014 08:54, Gopalasubramanian, Ganesh
>>>> <Ganesh.Gopalasubramanian@amd.com> wrote:
>>>>
>>>>> 2014-10-30 Ganesh Gopalasubramanian <Ganesh.Gopalasubramanian@amd.com>
>>>>
>>>> Check the whitespace in your ChangeLog line.
>>>>
>>>>> * config/arm/types.md (define_attr "type"): Add prefetch.
>>>>
>>>> The existing schedulers use 'load1'. We can of course split that into
>>>> two introducing "prefetch" and update all of the existing schedulers
>>>> to reflect the change. However I suggest we do that as a separate
>>>> activity when someone actually needs the distinction, note this change
>>>> will require updating the schedulers for both ARM and AArch64 backends
>>>> not just those relevant to AArch64. For this prefetch patch I suggest
>>>> we go with the existing "load1".
>>>
>>> I will need this change for ThunderX schedule. The Pref instruction
>>> is single issued while load1 can be dual issued.
>>
>> Hi
>>
>> https://gcc.gnu.org/ml/gcc-patches/2015-01/msg00802.html
>>
>> Philipp when you deal with Ramana's request above to split
>> load1->load1/prefetch in the existing schedulers I suggest you also
>> split it in aarch64/thunderx.md in order to retain existing behaviour.
>> Andrew can then follow up add the "right" behaviour when he is ready.
>> Andrew OK ?
>
> Yes that sounds ok to me. I was going to submit an update to
> thunderx.md file this week anyways.
>
> Thanks,
> Andrew
>
>
>>
>> Cheers
>> /Marcus