This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch docs 5/5] Update "Predicates" from md.texi
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: James Greenhalgh <james dot greenhalgh at arm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, gerald at pfeifer dot com, joseph at codesourcery dot com
- Date: Mon, 12 Jan 2015 22:37:17 +0000
- Subject: Re: [Patch docs 5/5] Update "Predicates" from md.texi
- Authentication-results: sourceware.org; auth=none
- References: <1420543302-11008-1-git-send-email-james dot greenhalgh at arm dot com> <1420543302-11008-6-git-send-email-james dot greenhalgh at arm dot com>
James Greenhalgh <james.greenhalgh@arm.com> writes:
> @@ -794,25 +805,25 @@ diagnosis when special predicates are used.
>
> These are the generic predicates available to all back ends. They are
> defined in @file{recog.c}. The first category of predicates allow
> -only constant, or @dfn{immediate}, operands.
> +only constant, or @dfn{immediate}, operands and are normal predicates.
>
> @defun immediate_operand
> This predicate allows any sort of constant that fits in @var{mode}.
> -It is an appropriate choice for instructions that take operands that
> -must be constant.
> +It is an appropriate choice for operands to an instruction which requires
> +a constant.
> @end defun
Maybe it's just me, but I find this quite hard to parse. How about
"for operands that accept any legitimate constant" (with a reference
to TARGET_LEGITIMATE_CONSTANT_P)?
> @@ -857,15 +871,15 @@ it should not be used directly.
> The third category of predicates allow only some kind of memory reference.
>
> @defun memory_operand
> -This predicate allows any valid reference to a quantity of mode
> +This predicate allows any valid reference to an objects of mode
> @var{mode} in memory, as determined by the weak form of
> @code{GO_IF_LEGITIMATE_ADDRESS} (@pxref{Addressing Modes}).
> @end defun
s/an objects/an object/
Thanks,
Richard