libgomp offloading testing (was: OpenACC middle end changes)

[Thomas Schwinge <thomas at codesourcery dot com>]

Hi Jakub!

On Thu, 18 Dec 2014 15:20:42 +0100, Jakub Jelinek <jakub@redhat.com> wrote:
> So, with your latest change both compilers build:
> mkdir objmic; cd objmic
> ../configure --build=x86_64-intelmicemul-linux-gnu --host=x86_64-intelmicemul-linux-gnu --target=x86_64-intelmicemul-linux-gnu --enable-as-accelerator-for=x86_64-pc-linux-gnu --disable-bootstrap
> make -j16
> make DESTDIR=`pwd`/../objinst install
> mkdir ../obj; cd ../obj
> ../configure --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --target=x86_64-pc-linux-gnu --enable-offload-targets=x86_64-intelmicemul-linux-gnu=/usr/src/gomp-4.0/objmic --disable-bootstrap
> make -j16

Thanks; I'll look into reproducing such a build.


> And in libgomp the testing fails completely:

What happens, in my understanding, is:

> Making check in testsuite
> make[1]: Entering directory '/usr/src/gomp-4.0/obj/x86_64-pc-linux-gnu/libgomp/testsuite'
> make  check-DEJAGNU
> make[2]: Entering directory '/usr/src/gomp-4.0/obj/x86_64-pc-linux-gnu/libgomp/testsuite'
> Making a new site.exp file...
> srcdir=`CDPATH="${ZSH_VERSION+.}:" && cd ../../../../libgomp/testsuite && pwd`; export srcdir; \
> EXPECT=expect; export EXPECT; \
> runtest="runtest "; \
> if /bin/sh -c "$runtest --version" > /dev/null 2>&1; then \
>   exit_status=0; l='libgomp'; for tool in $l; do \
>     if $runtest  --tool $tool --srcdir $srcdir ; \
>     then :; else exit_status=1; fi; \
>   done; \
> else echo "WARNING: could not find \`runtest'" 1>&2; :;\
> fi; \
> exit $exit_status
> WARNING: Couldn't find the global config file.
> ERROR: tcl error sourcing libgomp-test-support.exp.
> can't read "(target_alias)": no such variable

The variable $(target_alias) is not available when in the line:

>     while executing
> "set offload_additional_options " -B/usr/src/gomp-4.0/objmic/libexec/gcc/$(target_alias)/$(gcc_version) -B/usr/src/gomp-4.0/objmic/bin""

... in the file:

>     (file "libgomp-test-support.exp" line 5)
>     invoked from within
> "source libgomp-test-support.exp"

... it is being parsed.

Should target_alias and gcc_version be instantiated (AC_SUBST) by
Autoconf already, when creating the libgomp-test-support.exp file from
libgomp/testsuite/libgomp-test-support.exp.in?  Or, should those be
written (in libgomp/plugin/configfrag.ac) "in TCL syntax", and evaluated
only once libgomp-test-support.exp is sourced?  target_alias is being
provided in site.exp (as generated by libgomp/testsuite/Makefile), but
gcc_version is not.

>     ("uplevel" body line 1)
>     invoked from within
> "uplevel #0 source libgomp-test-support.exp"
>     invoked from within
> "catch "uplevel #0 source $file""
> Makefile:277: recipe for target 'check-DEJAGNU' failed
> make[2]: *** [check-DEJAGNU] Error 1
> make[2]: Leaving directory '/usr/src/gomp-4.0/obj/x86_64-pc-linux-gnu/libgomp/testsuite'
> Makefile:314: recipe for target 'check-am' failed
> make[1]: *** [check-am] Error 2
> make[1]: Leaving directory '/usr/src/gomp-4.0/obj/x86_64-pc-linux-gnu/libgomp/testsuite'
> Makefile:856: recipe for target 'check-recursive' failed
> make: *** [check-recursive] Error 1

> So clearly the *.exp files need to be taught where to look for libgomp-test-support.exp.

That's not the problem, if I'm understanding correctly.


GrÃÃe,
 Thomas

Attachment: pgpYIfl4lAs4T.pgp
Description: PGP signature