This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR64240
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: "Yangfei (Felix)" <felix dot yang at huawei dot com>,"gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 16 Dec 2014 10:00:45 +0100
- Subject: Re: [PATCH] Fix PR64240
- Authentication-results: sourceware.org; auth=none
- References: <DA41BE1DDCA941489001C7FBD7A8820E837AF45D at szxema507-mbx dot china dot huawei dot com>
On December 16, 2014 9:51:25 AM CET, "Yangfei (Felix)" <felix.yang@huawei.com> wrote:
>Hi,
>
>This patch fixes an obvious typo which may affect the DDG creation of
>SMS and make this optimization produce buggy code.
>Bootstrapped on x86_64-suse-linux. Also passed check-gcc test for
>aarch64-linux-gnu.
> OK for the trunk?
Do you have a testcase? If so please add it.
OK.
Thanks,
Richard.
>
>Index: gcc/ddg.c
>===================================================================
>--- gcc/ddg.c (revision 218582)
>+++ gcc/ddg.c (working copy)
>@@ -77,7 +77,7 @@ mark_mem_use (rtx *x, void *)
> {
> subrtx_iterator::array_type array;
> FOR_EACH_SUBRTX (iter, array, *x, NONCONST)
>- if (MEM_P (*x))
>+ if (MEM_P (*iter))
> {
> mem_ref_p = true;
> break;
>Index: gcc/ChangeLog
>===================================================================
>--- gcc/ChangeLog (revision 218582)
>+++ gcc/ChangeLog (working copy)
>@@ -1,3 +1,8 @@
>+2014-12-16 Felix Yang <felix.yang@huawei.com>
>+
>+ PR rtl-optimization/64240
>+ * ddg.c (mark_mem_use): Check *iter instead of *x.
>+
> 2014-12-10 Felix Yang <felix.yang@huawei.com>
>
> * config/aarch64/aarch64-protos.h (aarch64_function_profiler): Remove