This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 3/4] Add Visium support to gcc
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Eric Botcazou <ebotcazou at adacore dot com>
- Cc: <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 12 Dec 2014 00:26:21 +0000
- Subject: Re: [PATCH 3/4] Add Visium support to gcc
- Authentication-results: sourceware.org; auth=none
- References: <1697377 dot F6QTYBSkkH at polaris> <4304211 dot XWGjf9jolC at polaris>
Use of `%s' in diagnostics is long obsoleted by %qs (in this case, using
%qE with the identifier directly, rather than using IDENTIFIER_POINTER, is
preferred).
INTVAL / UINTVAL return HOST_WIDE_INT / unsigned HOST_WIDE_INT, not long /
unsigned long. You have lots of uses of fprintf that presume they return
long / unsigned long.
As you have the interrupt attribute, you need to add this port to the list
in extend.texi of ports with this attribute. (Generally, check the
checklist of pieces in sourcebuild.texi to update for a new port.)
At least one target for this port should be added to
contrib/config-list.mk (and you should verify that the port builds cleanly
with --enable-werror-always, for both 32-bit and 64-bit hosts, when
building using current trunk GCC).
--
Joseph S. Myers
joseph@codesourcery.com