This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH x86] Enable v64qi permutations.
- From: Robert Dewar <dewar at adacore dot com>
- To: Richard Henderson <rth at redhat dot com>, Ilya Tocar <tocarip dot intel at gmail dot com>, Uros Bizjak <ubizjak at gmail dot com>, Jakub Jelinek <jakub at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 10 Dec 2014 11:52:19 -0500
- Subject: Re: [PATCH x86] Enable v64qi permutations.
- Authentication-results: sourceware.org; auth=none
- References: <20141204094959 dot GA67582 at msticlxl7 dot ims dot intel dot com> <548879B5 dot 7080403 at redhat dot com>
On 12/10/2014 11:49 AM, Richard Henderson wrote:
On 12/04/2014 01:49 AM, Ilya Tocar wrote:
+ if (!TARGET_AVX512BW || !(d->vmode == V64QImode))
Please don't over-complicate the expression.
Use x != y instead of !(x == y).
To me the original reads more clearly, since it
is of the parallel form !X or !Y, I don't see it
as somehow more complicated???
r~