This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix libgomp crash without TLS (PR42616)
- From: Varvara Rainchik <varvara dot s dot rainchik at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Richard Henderson <rth at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 9 Dec 2014 14:49:44 +0300
- Subject: Re: Fix libgomp crash without TLS (PR42616)
- Authentication-results: sourceware.org; auth=none
- References: <20140930095219 dot GA1986 at tucnak dot redhat dot com> <542AC0F4 dot 9090808 at redhat dot com> <CAAp9h92JrSYjicz1A2ysfNniXAVk2LkE9WsLNiGXQehgS2yKdQ at mail dot gmail dot com> <20141007071125 dot GE1986 at tucnak dot redhat dot com> <CAAp9h91_2rLg8_GsNcaiA5D9MuTcUiskxkufdydENok1OAxLZQ at mail dot gmail dot com> <CAAp9h91yhuDnD607RO4+=E8DFVfrMKpN5kAa9nCzsq8_XqeTuw at mail dot gmail dot com> <CAAp9h921vFhhu+-6-SsRnN9kqP1SGfO+enciwXw4FoP26UfmcA at mail dot gmail dot com> <CAAp9h900CX-Fxu2inY35xf7rf29ZoFN88kwGUwy2bP_smW6s-g at mail dot gmail dot com> <20141208140352 dot GJ1667 at tucnak dot redhat dot com> <CAAp9h933G6OvF4MkKyjOfjck+27o++Q1G0s7YX9exEpatFepgw at mail dot gmail dot com> <20141208162816 dot GK1667 at tucnak dot redhat dot com>
Can we instead of adding new macroses in config/tls.m4 use something
like that in libgomp:
#if defined (HAVE_TLS) && defined (USE_EMUTLS)
(with GCC_CHECK_EMUTLS in libgomp/configure.ac)?
2014-12-08 19:28 GMT+03:00 Jakub Jelinek <jakub@redhat.com>:
> On Mon, Dec 08, 2014 at 07:01:09PM +0300, Varvara Rainchik wrote:
>> Is it ok to add GCC_CHECK_EMUTLS test in libgomp/configure.ac or
>> should I add in tls.m3 a similair test that would be used only in
>> libgomp?
>
> I think config/tls.m4 would be a better place, but doing it in some way
> where the users of config/tls.m4 could actually by using different macros
> from there choose what they want (either check solely for real TLS, or
> only for emutls, or for both). And libgomp/configure.ac would then choose
> it is happy with both.
>
> Jakub