This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: FW: [PATCH] Fix PR ipa/64049
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Richard Biener <richard dot guenther at gmail dot com>
- Cc: Bernd Edlinger <bernd dot edlinger at hotmail dot de>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <hubicka at ucw dot cz>
- Date: Mon, 8 Dec 2014 23:49:57 +0100
- Subject: Re: FW: [PATCH] Fix PR ipa/64049
- Authentication-results: sourceware.org; auth=none
- References: <DUB118-W49097CA70585F4128C2AC9E4640 at phx dot gbl> <DUB118-W4945E53800785CF3BB5C32E4640 at phx dot gbl> <CAFiYyc3U1f0dA774+_-bBwJ4foFaxqRQmYyUzE65pKgMfJ_3bQ at mail dot gmail dot com>
> On Mon, Dec 8, 2014 at 11:57 AM, Bernd Edlinger
> <bernd.edlinger@hotmail.de> wrote:
> >
> >
> >>
> >> Hello,
> >>
> >>
> >> this surprisingly simple patch fixes PR ipa/64049. The root cause seems to be
> >> that in this test case we try to devirtualize a method call on a return value.
> >>
> >>
> >> Boot-Strapped and regression-tested on X86_64-linux-gnu.
> >> OK for trunk?
>
> I think positive tests, in this case TREE_CODE (...) == VAR_DECL
> are better.
>
> Ok with that change.
The test there assumes that only values with well defined default value are parm decls,
so in cases we see a call on default value of other kind of decl, we could turn it
to undefined call.
In what cases has RESULT_DECL sane initial value? We should at least drop a comment here.
Honza
>
> Thanks,
> Richard.
>
> >>
> >> Thanks
> >> Bernd.
> >>
> >
> > Again with changelog. Sorry.
> >