This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch c++]: Fix PR/64127 ICE on invalid: tree check: exprected identifier_node, have template_id_expr in cp_parser_diagnose_invalid_type_name
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Kai Tietz <ktietz70 at googlemail dot com>
- Cc: Marek Polacek <polacek at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Jason Merrill <jason at redhat dot com>
- Date: Thu, 4 Dec 2014 17:32:18 +0100
- Subject: Re: [patch c++]: Fix PR/64127 ICE on invalid: tree check: exprected identifier_node, have template_id_expr in cp_parser_diagnose_invalid_type_name
- Authentication-results: sourceware.org; auth=none
- References: <CAEwic4YDKvn=YqzfpKAUyWUEMS-LkCdDwzeOaXd=jt-2n_5-ag at mail dot gmail dot com> <20141204154715 dot GF16332 at redhat dot com> <CAEwic4Zafj-jFiEB4jXHjNZsOpBu5UtAux9c+Ee8onX7979jVA at mail dot gmail dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Dec 04, 2014 at 04:59:21PM +0100, Kai Tietz wrote:
> Same as said before. Issue is a invalid-code bug with ICE, and
> error-messages are pretty meaningless. It would be helpful to have in
> testsuite just the opportunity to test for no ICE.
You can add just // { dg-error "" } on all lines that are diagnosed,
the ICE should FAIL the test anyway. Please verify it by checking
the testcase fails without the patch and succeeeds with the patch.
> Anyway, if testcase is requested, I can add it to g++.dg/ collection
Yes, please.
Jakub