This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Improve spillcost of literal pool loads

From: Jeff Law <law at redhat dot com>
To: Wilco Dijkstra <wdijkstr at arm dot com>, gcc-patches at gcc dot gnu dot org
Date: Mon, 01 Dec 2014 10:31:54 -0700
Subject: Re: [PATCH] Improve spillcost of literal pool loads
Authentication-results: sourceware.org; auth=none
References: <002201cff37b$5145f560$f3d1e020$ at com> <545152C7 dot 40405 at redhat dot com> <000201d00b15$0dc16020$29442060$ at com>

On 11/28/14 07:10, Wilco Dijkstra wrote:

Jeff Law wrote:
Do you have a testcase that shows the expected improvements from this
change?  It's OK if it's specific to a target.

Have you bootstrapped and regression tested this change?

With a test for the testsuite and assuming it passes bootstrap and
regression testing, this will almost certainly be OK.


I've added a test, see below. It bootstraps OK on AArch64 and the only
difference in the regression tests after the patch is the one extra pass.

OK for commit?

OK with the appropropriate ChangeLog entires. THe original forira-costs.c was fine, so you just need the trivial one for the testcase.


jeff

Follow-Ups:
- RE: [PATCH] Improve spillcost of literal pool loads
  - From: Wilco Dijkstra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]