This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR15346


On Mon, Dec 01, 2014 at 04:10:35PM +0100, Richard Biener wrote:
> On Mon, 1 Dec 2014, Ulrich Weigand wrote:
> 
> > Richard Biener wrote:
> > 
> > > 	* Makefile.in (gimple-match.o-warn): Remove -Wno-unused-parameter,
> > > 	add -Wno-unused-but-set-variable.
> > 
> > This seems to cause
> > 
> > cc1plus: error: unrecognized command line option "-Wno-unused-but-set-variable"                                                                                                    
> > make[3]: *** [gimple-match.o] Error 1                                                                                                                                              
> > 
> > in stage1 when bootstrapping on SLES 11 (gcc 4.3.4 host compiler).
> 
> Oh.  Hmm, so I guess
> 
> build/gengtype-lex.o-warn = -Wno-error
> gengtype-lex.o-warn = -Wno-error
> 
> and friends are also incorrect for host compilers that do not know
> -Wno-error?  Which means we need configure checks and substitutes
> for all -Wno-X we use.  4.3 has -Wunused so I can just replace
> -Wno-unused-variable -Wno-unused-but-set-variable with
> -Wno-unused as a quick fix for you.  Will do that now (I didn't
> want to use -Wno-error because that makes the compile quite
> uselessly verbose and fails to diagnose real issues).

No, -Wno-error or -Wno-unused in there is just fine.
$($(@D)-warn) and $($@-warn) are only added to GCC_WARN_C{,XX}FLAGS vars
and those are added only if the compiler is GCC.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]