This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][OpenMP] Fix named critical sections inside target functions
- From: Ilya Verbin <iverbin at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Kirill Yukhin <kirill dot yukhin at gmail dot com>
- Date: Sat, 22 Nov 2014 00:08:38 +0300
- Subject: Re: [PATCH][OpenMP] Fix named critical sections inside target functions
- Authentication-results: sourceware.org; auth=none
- References: <20141121201926 dot GC63468 at msticlxl57 dot ims dot intel dot com> <20141121203644 dot GK1745 at tucnak dot redhat dot com>
> On 21 Nov 2014, at 23:36, Jakub Jelinek <jakub@redhat.com> wrote:
>
>> On Fri, Nov 21, 2014 at 11:19:26PM +0300, Ilya Verbin wrote:
>> Hi,
>>
>> '#pragma omp critical (name)' can be placed in the function, marked
>> with '#pragma omp declare target', in this case the corresponding node
>> should be marked as offloadable too.
>> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>
> Please add a testcase for this.
By default with disabled offloading it will always PASS. Add anyway?
-- Ilya