This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR jit/63969: Fix segfault in error-handling when driver isn't found
- From: David Malcolm <dmalcolm at redhat dot com>
- To: Mike Stump <mikestump at comcast dot net>
- Cc: Gcc Patch List <gcc-patches at gcc dot gnu dot org>, law at redhat dot com
- Date: Thu, 20 Nov 2014 09:33:08 -0500
- Subject: Re: [PATCH] PR jit/63969: Fix segfault in error-handling when driver isn't found
- Authentication-results: sourceware.org; auth=none
- References: <1416464586 dot 11511 dot 6 dot camel at surprise> <735613C9-1D12-4320-A68E-82B06578AF81 at comcast dot net>
On Wed, 2014-11-19 at 23:09 -0800, Mike Stump wrote:
> On Nov 19, 2014, at 10:23 PM, David Malcolm <dmalcolm@redhat.com>
> wrote:
> > It's not clear to me if I can approve my own patches to the jit
>
> So, to answer that, we look at MAINTAINERS, and look up your name:
>
> Various Maintainers
>
> jit David Malcolm <dmalcolm@redhat.com>
>
> So, this means that you can review other peoples work and approve it
> for the jit code, and you can review and approve your own work for the
> jit code. This is the definition of Maintainer. If you had been
> listed under Reviewers, you would need approval for your own work.
>
> Now, that doesnât mean, you canât ask for a review for any reason you
> want. :-)
[CCing Jeff]
Indeed, but Jeff wrote in another thread:
> JIT space, yours to approve :-) We haven't formalized that
> yet, but it'd be silly to do anything else.
[ https://gcc.gnu.org/ml/gcc-patches/2014-11/msg02514.html ]
...and that got me wondering if:
(A) there's an additional governance step here that should happen, or
(B) if I can go ahead and commit suitably tested patches that are
confined to the:
gcc/jit
gcc/testsuite/jit.exp
subdirectories (and approve other people's such patches), or
(C) both i.e. do (B) whilst (A) is pending
Thanks
Dave