This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] rs6000: Fix signed integer overflows
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: Markus Trippelsdorf <markus at trippelsdorf dot de>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 19 Nov 2014 11:20:05 -0500
- Subject: Re: [PATCH] rs6000: Fix signed integer overflows
- Authentication-results: sourceware.org; auth=none
- References: <20141119152425 dot GG344 at x4>
On Wed, Nov 19, 2014 at 10:24 AM, Markus Trippelsdorf
<markus@trippelsdorf.de> wrote:
> bootstrap-ubsan on gcc112 shows a couple of signed integer overflows:
> The fix was tested on powerpc64-unknown-linux-gnu.
> OK for trunk?
>
> Thank you.
>
> 2014-11-19 Markus Trippelsdorf <markus@trippelsdorf.de>
>
> * config/rs6000/constraints.md: Avoid signed integer overflows.
> * config/rs6000/predicates.md: Likewise.
This is okay. IN_RANGE is clearer, but you don't have to clean up comparison.
UINTVAL is prettier, but not necessary. A lot of code in GCC is not
careful about that.
Thanks, David