This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C PATCH] warn for empty struct -Wc++-compat
- From: Prathamesh Kulkarni <bilbotheelffriend at gmail dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: Marek Polacek <polacek at redhat dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 15 Nov 2014 03:56:58 +0530
- Subject: Re: [C PATCH] warn for empty struct -Wc++-compat
- Authentication-results: sourceware.org; auth=none
- References: <CAJXstsAQ0GLXs7rYJeZTY1_ccgS84HXkU+X7pKKNfQPmh8TGHw at mail dot gmail dot com> <20141110220517 dot GF10852 at redhat dot com> <CAJXstsD3b4Ma7q1VpmOcDaVi5G5Tijk0O2S0ex6yCXrdiDPvWA at mail dot gmail dot com> <20141111110023 dot GG10852 at redhat dot com> <CAJXstsCF0B7x=BpK9uZv6usxS7nU6uYr265Hr0P3AgKPk06_rA at mail dot gmail dot com> <20141111195814 dot GJ10852 at redhat dot com> <CAJXstsDk_9Amb+PLbGzbKLe1MrdFQLCT4yKSP3Xe-tE36KvRwA at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1411142136130 dot 31777 at digraph dot polyomino dot org dot uk>
On Sat, Nov 15, 2014 at 3:06 AM, Joseph Myers <joseph@codesourcery.com> wrote:
> On Wed, 12 Nov 2014, Prathamesh Kulkarni wrote:
>
>> Is this version okay ?
>> [gcc/c]
>> * c-decl.c (warn_cxx_compat_finish_struct): New parameters code, record_loc.
>> Warn for empty struct.
>> (finish_struct): Pass TREE_CODE (t) and loc to
>> warn_cxx_compat_finish_struct.
>>
>> [gcc/testsuite/gcc.dg]
>> * Wcxx-compat-22.c: New test-case.
>
> OK.
Thanks. I will perform complete regression testing, and post the patch
with modifications to test cases that
may possibly break due to this warning.
Regards,
Prathamesh
>
> --
> Joseph S. Myers
> joseph@codesourcery.com