This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] New std::string implementation
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: Christopher Jefferson <chris at bubblescope dot net>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 14 Nov 2014 16:42:14 +0000
- Subject: Re: [patch] New std::string implementation
- Authentication-results: sourceware.org; auth=none
- References: <20141114154330 dot GH5191 at redhat dot com> <CA+jCFLuwk2Bz=p1C=qkL1xAD7=ObAx9SRv4kGskUrnbQcavBCw at mail dot gmail dot com>
On 14/11/14 16:32 +0000, Christopher Jefferson wrote:
Some (very small) questions / cleanups
1) Do you plan on supporting CXX11 ABI on C++03? There is some #if
__cplusplus < 201103L inside the new basic_string.
Yes, the intention is that you get the same std::string implementation
independent of the -std option you use, so that C++03 and C++11 code
is compatible and can be linked together.
So although the tag is named "cxx11" that refers to the fact that
this ABI change is required for C++11 conformance, not that it only
applies to code compiled with -std=c++11 or -std=gnu++11.
2) Is there a need for the #if 0 _M_mutate?
Oops, no, I meant to take that out. I'll do it before committing.
I tried bootstrapping on Mac OS X 10.10, and got lots of linking
issues, the relevant part is::
I might be missing some of the new instantiations, I'll look into
that.
Thanks for checking it!