This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 4/5] OpenACC 2.0 support for libgomp - new tests (repost)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Julian Brown <julian at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Thomas Schwinge <thomas at codesourcery dot com>, Ilya Verbin <iverbin at gmail dot com>
- Date: Thu, 13 Nov 2014 11:15:18 +0100
- Subject: Re: [PATCH 4/5] OpenACC 2.0 support for libgomp - new tests (repost)
- Authentication-results: sourceware.org; auth=none
- References: <20140923192033 dot 7c2c2f00 at octopus> <20141111135442 dot 4284c3de at octopus>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Nov 11, 2014 at 01:54:42PM +0000, Julian Brown wrote:
> @@ -169,6 +192,57 @@ proc libgomp_init { args } {
>
> # Disable color diagnostics
> lappend ALWAYS_CFLAGS "additional_flags=-fdiagnostics-color=never"
> +
> + # TODO. Evil hack. DejaGnu doesn't have a mechanism for setting
> + # environment variables on remote boards. Thus, we have to fake it, using
> + # GCC's constructor attributes to create object files that install the
> + # desired environment variables.
...
Please don't add ugly hacks, I thought Thomas said you didn't mean to put
this in.
> +global shlib_ext
> +
> +set shlib_ext [get_shlib_extension]
> +#TODO
???
> +# Turn on OpenACC.
> +# XXX (TEMPORARY): Remove the -flto once that's properly integrated.
> +lappend ALWAYS_CFLAGS "additional_flags=-fopenacc -flto"
Do you still need that?
> + # Todo: get list of accelerators from configure options --enable-accelerator.
> + set accels { "nvidia" "host_nonshm" }
I hope intelmicemul and intelmic will be added here soon.
> + # Todo: Determine shared memory or not using run-time test.
Please just do that using the run-time test.
Jakub