This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [PATCHv4][MIPS] Implement O32 ABI extensions (GCC)
- From: Matthew Fortune <Matthew dot Fortune at imgtec dot com>
- To: "Moore, Catherine" <Catherine_Moore at mentor dot com>, "'gcc-patches at gcc dot gnu dot org' (gcc-patches at gcc dot gnu dot org)" <gcc-patches at gcc dot gnu dot org>, "Eric Christopher (echristo at gmail dot com)" <echristo at gmail dot com>
- Cc: Richard Sandiford <rdsandiford at googlemail dot com>, Rich Fuhler <Rich dot Fuhler at imgtec dot com>, "Rozycki, Maciej" <Maciej_Rozycki at mentor dot com>, "Myers, Joseph" <joseph_myers at mentor dot com>
- Date: Wed, 12 Nov 2014 18:58:39 +0000
- Subject: RE: [PATCHv4][MIPS] Implement O32 ABI extensions (GCC)
- Authentication-results: sourceware.org; auth=none
- References: <6D39441BF12EF246A7ABCE6654B0235320F6BF71 at LEMAIL01 dot le dot imgtec dot org> <FD3DCEAC5B03E9408544A1E416F11242018910FCCD at NA-MBX-01 dot mgc dot mentorg dot com>
Moore, Catherine <Catherine_Moore@mentor.com> writes:
> The patch looks good. Please fix up these couple of nits prior to
> committing.
OK, thanks for the second read through. One further amendment below, I'll
aim to commit later today.
> Index: gcc/config/mips/mips.c
> ===================================================================
> --- gcc/config/mips/mips.c (revision 217363)
> +++ gcc/config/mips/mips.c (working copy)
> @@ -18824,6 +19000,21 @@ mips_expand_vec_minmax (rtx target, rtx op0, rtx
> o
> emit_insn (gen_rtx_SET (VOIDmode, target, x)); }
>
> +/* Implement HARD_REGNO_CALLER_SAVE_MODE. */
> +
> +machine_mode
> +mips_hard_regno_caller_save_mode (unsigned int regno,
> + unsigned int nregs,
> + machine_mode mode) {
> + /* For performance, to avoid saving/restoring upper parts of a
> register,
> + we return MODE as save mode when MODE is not VOIDmode. */
>
> s/performance, to/performance, /
>
The second part of this sentence will need to change too I think:
For performance, avoid saving/restoring upper parts of a register
by returning MODE as save mode when the mode is known.
Thanks,
Matthew