This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Optimize UBSAN_NULL checks, add sanopt.c
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Maxim Ostapenko <m dot ostapenko at partner dot samsung dot com>
- Cc: Yury Gribov <y dot gribov at samsung dot com>, Marek Polacek <polacek at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Konstantin Serebryany <konstantin dot s dot serebryany at gmail dot com>
- Date: Wed, 12 Nov 2014 11:10:08 +0100
- Subject: Re: [PATCH] Optimize UBSAN_NULL checks, add sanopt.c
- Authentication-results: sourceware.org; auth=none
- References: <20141105102918 dot GX20462 at redhat dot com> <20141105105020 dot GC5026 at tucnak dot redhat dot com> <20141105112337 dot GY20462 at redhat dot com> <545A1531 dot 6020404 at samsung dot com> <20141105122152 dot GF5026 at tucnak dot redhat dot com> <545A1945 dot 2040608 at samsung dot com> <545A225D dot 9050808 at samsung dot com> <20141105132301 dot GH5026 at tucnak dot redhat dot com> <545A2A91 dot 9020900 at samsung dot com> <54631E78 dot 1010105 at partner dot samsung dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Nov 12, 2014 at 12:46:48PM +0400, Maxim Ostapenko wrote:
>
> >>If in the future we e.g. IPA-prop propagate the nonfreeing_call_p
> >>property through the callgraph (as in, if the function you call
> >>is non-overridable and you know the flag for it, use it),
> >
> >FYI we tried this on SPEC and some other apps but saw no performance
> >improvements.
> >
> Yes, we have a patch for this kind of analysis, but it doesn't produce
> reasonable performance improvements indeed. Anyway, we are able to perform
> measurements once again on top of your patch if you decide to commit it.
If you have a patch written for the IPA propagation of nonfreeing_call_p,
can you post it? Even if you don't see significant improvements from it,
if the pass isn't too costly (especially if it can be propagated in
some existing pass together with other analysis), then it might sense to add
it anyway. nonfreeing_call_p isn't used just by asan.
Jakub
- References:
- Re: [PATCH] Optimize UBSAN_NULL checks, add sanopt.c
- Re: [PATCH] Optimize UBSAN_NULL checks, add sanopt.c
- Re: [PATCH] Optimize UBSAN_NULL checks, add sanopt.c
- Re: [PATCH] Optimize UBSAN_NULL checks, add sanopt.c
- Re: [PATCH] Optimize UBSAN_NULL checks, add sanopt.c
- Re: [PATCH] Optimize UBSAN_NULL checks, add sanopt.c
- Re: [PATCH] Optimize UBSAN_NULL checks, add sanopt.c
- Re: [PATCH] Optimize UBSAN_NULL checks, add sanopt.c
- Re: [PATCH] Optimize UBSAN_NULL checks, add sanopt.c
- Re: [PATCH] Optimize UBSAN_NULL checks, add sanopt.c